https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #39 from Nick Clemens <n...@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #37) > starting with a first code review here: > 1) There seem to be a few lines doubled up in AddIssue now: Fixed > 2) This line is a change of behaviour: Before the change was dependent on > the system preference - now it will always happen? In practice the only way to have the scenario of location=CART and permanentlocation!=CART was via the syspref and is now via the new syspref - I don't think we are acutally changing behaviour here > 3) ReturnToShelvingCart is removed from the code, but the system preference > is not deleted in the database update. Not sure what you mean? Below is in atomic update DELETE FROM systempreferences WHERE variable='ReturnToShelvingCart'; > 4) koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js contains strings - > those can not be translated (js files can't be in general) Ah, yes, moved > 5) Tests are failing for me (run within koha-shell in kohadevbox): Fixed! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
