https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
--- Comment #29 from Aleisha Amohia <[email protected]> --- (In reply to Jonathan Druart from comment #27) > Aleisha, Have a look at your patches, there are some weird stuffs to fix: > 1/ kohastructure: you re-add the entire item table > 2/ update db: you should specify the "after" sql clause to keep the same > order as the kohastructure (not necessary useful but good practice to have) > 3/ There is no need to use strict and warnings alongside Modern::Perl; > 4/ The svc script has a BibLibre copyright > 5/ I don't understand the need of the new subroutine in the svc script > (ajax_auth_cgi). You should not need it, have a look at how the other svc > scripts deal with authentication > 6/ QA script fails with: > FAIL installer/data/mysql/sysprefs.sql > FAIL sysprefs_order > Not blocker: Sysprefs AllowIssueNotes is bad placed (see bug > 10610) Hi Jonathan, I fixed all of these except the first point - what do you mean I re-add the entire items table? Sorry, I don't understand. Aleisha -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
