https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Owen Leonard <[email protected]> --- I think this is a great new feature. A few issues and suggestions: - The preference should be retrieved via the template instead of in the Perl script: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML7:_use_system_preference_TT_plugin - The date in the checkin message should be formatted using the KohaDates plugin. - On the circulation page, I think it makes more sense to put the patron note in the column which shows the "Checked in" message since that's where the librarian would be looking for confirmation of the transaction. Since there is no way to find out what note was attached to something you just checked in on returns.pl, I wonder if the notification shouldn't work the same as the hold notice: In a blocking modal? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
