https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
--- Comment #38 from M. Tompsett <[email protected]> --- Comment on attachment 58846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58846 Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script Review of attachment 58846: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58846) ----------------------------------------------------------------- Nice improvements. Sorry if I was a little harsh before. You are doing great for your first major attempt. I say major, because you are affecting more than one file and adding a really nice pre-configuration setup. The fact that you are trying and listening to feedback is plus in my books! Keep up the effort. :) I'll test it in a bit. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt @@ -43,4 @@ > </form> > > [%ELSE %] > - <!--Implement if statement to determine if library was > succesfully created here....--> I'm just eyeballing this right now, but was this already dealt with? Why remove it? ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt @@ -191,4 @@ > </li> > <li> > <label for="passwordlabel" > class="required">Password: </label> > - <input type="password" name="password" > pattern="[A-Za-z1-9 ]+" title="Please only enter letters or numbers into this > password field" id="password" size="20" value="[% member.password |html %]" > class="required" required="required"> Thank you for removing this pattern stuff. The alternative was to include those special characters, but then you would have to escape some of them. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt @@ +42,5 @@ > <p> To create another item type later and for more > setttings <br> > + go to: <br><br> > + More->Administration->Item types <br> > + or<br> > + Administration->Item types Everything with - or not. And if there are things without, then without is the way you should do it to maintain consistency. Plus, I do not think the or part is necessary. ::: koha-tmpl/intranet-tmpl/prog/en/modules/summary.tt @@ +16,5 @@ > <fieldset style="font-size:120%"> > <h2>Library</h2> > <p> To add another library and for more settings, go to </br> > + More > Administration > Libraries and groups </p> OR<br> > + Administration->Libraries and groups There is no - in the original line. Also, no need for this change. @@ +21,5 @@ > > <h2>Patron Category</h2> > <p>To add another patron category and for more settings, go > to</br> > + More > Administration > Patron Categories</p> OR <br> > + Administration->Patron categories There is no - in the original line. Also, no need for this change. @@ +30,5 @@ > > <h2>Item Type</h2> > <p>To create another item type and for more settings, go to</br> > + More > Administration > Item types </p> OR <br> > + Administration->Item types There is no - in the original line. Also, no need for this change. ::: summary.pl @@ -21,5 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; > - > -use CGI qw ( -utf8 ); I would have kept this, since you have my $query = new CGI; later. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
