https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #46 from M. Tompsett <[email protected]> ---
Comment on attachment 58886
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58886
Bug 17855 -Fifth update following tester feedback.

Review of attachment 58886:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58886)
-----------------------------------------------------------------

This is from my quick eyeball check. Now to test.

::: installer/onboarding.pl
@@ -143,4 @@
>      $template->param( itemtypes => $itemtypes, );
>  }
>  elsif ( $step && $step == 1 ) {
> -    my $createlibrary = $input->param('createlibrary'); #Store the inputted 
> library branch code and name in $createlibrary variable

Not a biggie, but in the future put comments above, so that perl tidy doesn't
put the semi-colon on the next line which is harder to read.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ -40,5 @@
> -            },
> -            userid: {
> -                required: true;
> -                letters_numbers: true
> -            },

Why is this removed?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to