https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293
--- Comment #3 from Lari Taskula <[email protected]> --- Comment on attachment 67070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67070 Bug 19293: Prevent error when receiving shipment with order with deleted biblio Review of attachment 67070: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19293&attachment=67070) ----------------------------------------------------------------- Test plan works, just some small thoughts for the patch. Also I noticed test plan was dropped from the commit message after the sign-off. ::: acqui/parcel.pl @@ +225,4 @@ > for (my $i = 0 ; $i < $countpendings ; $i++) { > my $order = $pendingorders->[$i]; > > + unless( !defined $order->{biblionumber} ){ # if this biblio has been > deleted and the orderline hasn't been cancelled if ( defined $order->{biblionumber} ) { Or perhaps even next unless defined $order->{biblionumber}; to avoid having to fix indendation of 80+ lines below. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
