https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293
--- Comment #7 from Aleisha Amohia <[email protected]> --- (In reply to Lari Taskula from comment #3) > Comment on attachment 67070 [details] [review] > Bug 19293: Prevent error when receiving shipment with order with deleted > biblio > > Review of attachment 67070 [details] [review]: > ----------------------------------------------------------------- > > Test plan works, just some small thoughts for the patch. Also I noticed test > plan was dropped from the commit message after the sign-off. > > ::: acqui/parcel.pl > @@ +225,4 @@ > > for (my $i = 0 ; $i < $countpendings ; $i++) { > > my $order = $pendingorders->[$i]; > > > > + unless( !defined $order->{biblionumber} ){ # if this biblio has > > been deleted and the orderline hasn't been cancelled > > if ( defined $order->{biblionumber} ) { > > Or perhaps even > next unless defined $order->{biblionumber}; > to avoid having to fix indendation of 80+ lines below. There we go, changed the line to if ( defined $order->{biblionumber} ) { and put test plan back in commit message. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
