https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #43 from Josef Moravec <josef.mora...@gmail.com> --- Comment on attachment 70335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70335 Bug 17656 - Keep irregularities during subscription renewals Review of attachment 70335: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70335) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc @@ +1,5 @@ > +<p><em> > + If there is a day (or more) in the week where issues are never > + published, you can check corresponding boxes below. > +</em></p> > +[% daily_choice = [ {name => 'monday', desc => 'Monday', value => 1}, {name > => 'tuesday', desc => 'Tuesday', value => 2}, {name => 'wednesday', desc => > 'Wednesday', value => 3}, {name => 'thursday', desc => 'Thursday', value => > 4}, {name => 'friday', desc => 'Friday', value => 5}, {name => 'saturday', > desc => 'Saturday', value => 6}, {name => 'sunday', desc => 'Sunday', value > => 7} ] %] This way the day names are not translatable ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc @@ +1,5 @@ > +<p><em> > + If there is a month (or more) in the year where issues are never > + published, you can check corresponding boxes below. > +</em></p> > +[% monthly_choice = [ {name => 'january', desc => 'January', value => 1}, > {name => 'february', desc => 'February', value => 2}, {name => 'march', desc > => 'March', value => 3}, {name => 'april', desc => 'April', value => 4}, > {name => 'may', desc => 'May', value => 5}, {name => 'june', desc => 'June', > value => 6}, {name => 'july', desc => 'July', value => 7}, {name => 'august', > desc => 'August', value => 8}, {name => 'september', desc => 'September', > value => 9}, {name => 'october', desc => 'October', value => 10}, {name => > 'november', desc => 'November', value => 11}, {name => 'december', desc => > 'December', value =>12} ] %] Month names are not translatable ::: t/Koha/DateUtils.t @@ +26,5 @@ > + > +my $dt = DateTime->new(year => 2017, month => 1, day => 1); > + > +eval { issue_number('2017', 'day'); }; > +is($@, 'Date passed to issue_number is not a valid DateTime object'); Could you please also test if the ref() of exception has right class? @@ +40,5 @@ > +is(issue_number($dt, 'day'), 6, '2022-09-17 is the sixth day of week'); > + > +is(issue_number($dt, 'week'), 37, '2022-09-17 is the week #37 of the year'); > + > +is(issue_number($dt, 'month'), 9, '2017-09-17 is the ninth month of the > year'); should be 2022-09-17 ... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/