https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #49 from Josef Moravec <[email protected]> --- (In reply to Alex Arnaud from comment #46) > (In reply to Josef Moravec from comment #44) > > Comment on attachment 70336 [details] [review] [review] > > Bug 17656 - Update irregularities on subscription renewals > > > > Review of attachment 70336 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > > > Better to add new subs just to Koha namespace... but I understand it here - > > we do not have all the objects needed for serials management (frequencies > > and number patterns are missing) and calling C4 subs from Koha namespace is > > not good idea... If you are not willing to add needed objects, we could just > > fill a bug for now... > > Don't understand. You mean create Koha::Subscription->GuessEnddate? Yes, that is what I ment. > > > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt > > @@ +52,5 @@ > > > + <input type="hidden" id="numbering3" value="[% numbering3 %]" /> > > > + <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 > > > %]" /> > > > + <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 > > > %]" /> > > > + <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 > > > %]" /> > > > + <input type="hidden" id="locale" value="[% locale %]" /> > > > > Why do you include all the data when renewing subscription? It should be not > > needed! > > Yes. testPredictionPattern js function needs all the data. Then I think the showpredictionpattern.pl script should be changed to use stored data for parameters which weren't changed... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
