Benjamin Rokseth <> changed:

           What    |Removed                     |Added
  Attachment #57293|0                           |1
        is obsolete|                            |

--- Comment #6 from Benjamin Rokseth <> ---
Created attachment 72678
Bug 17561 - ReserveSlip needs itemnumber for item level holds on same biblio

This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both
6) also note that there is no itemnumber or barcode in the requests from
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

Run tests:
should fail before patch and pass after

You are receiving this mail because:
You are watching all bug changes.
Koha-bugs mailing list
website :
git :
bugs :

Reply via email to