https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Katrin Fischer <[email protected]> --- There are some mostly small issues: 1) Small rebase conflict in SQL files for permissions 2) Capitalization +<title>Home › Circulation › Checkout Notes</title> 2) Translatability $("#status_" + $issue_id).text("Not seen"); $("#status_" + $issue_id).text("Seen"); 3) Move JavaScript to the bottom - we are currently migrating all pages to do that. See: Bug 17858 - Omnibus: Move staff client JavaScript to the footer 4) Missing [% VERSION %] variable for JavaScript libraries: +<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.checkboxes.min.js"></script> See: Bug 12904 - Force browser to load new JavaScript and CSS files after upgrade 5) Typo: + ( 1, 'manage_checkout_nots', 'Mark checkout notes as seen/not seen'), 6) There are also some issues noted by the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in css paths (bug 12904) - May be false positive (line 7) forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 76) FAIL valid_template parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt line 134: unexpected token ([) [% note.patron.title [% END %] FAIL circ/on-site_checkouts.pl FAIL valid Global symbol "$pending_onsite_notes" requires explicit package name circ/on-site_checkouts.pl had compilation errors. I've tried to test, but I can't see the link on the circulation home page, possibly to a problem (typo?) with the permissions. Please fix and test. Thank you! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
