https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #171 from Alex Buckley <alexbuck...@catalyst.net.nz> --- Created attachment 82220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82220&action=edit Bug 15565: (follow-up) Moved function form C4/Reserves to Koha/Biblio Also updated t/db_dependen/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe a modal box loads to inform you that you have reached the maximum holds allowed today. 6. Click 'OK' on the modal and notice the first checkbox is selected and other unchecked checkboxes are disabled. 7. Repeat step 4 this time setting holds per day to 5 8. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays and select another item checkbox (so you have 2 selected checkboxes). Observe a modal saying you have reached the maximum number of holds for the record is loaded 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
