https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #174 from Katrin Fischer <[email protected]> --- Some first comments here: 1) CSS Something is off here, there is no more less directory on master: http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-tmpl/bootstrap;hb=e112c6f117d4b6fd6c6160e8be9cba4186db1279 koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 2644 ++++++++++++++++++++++++++++++++++++++++++++ Also I think generated .css files should not be included. 2) Asking Joubu to glance at the code, 2 more things (non-blocker): foreach my $item ( $self->items()->as_list() ) { would be better as: while ( my $item = $items->next ) { And tests should be in their own subtest. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
