https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |[email protected] --- Comment #24 from Katrin Fischer <[email protected]> --- You've asked for feedback from the QA team... so I'll try: 1) QA tools: FAIL valid_template parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt line 186: unexpected token (|) [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist || warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs | warnUploadPublic %] 2) Would 'direct' be more fitting than 'public' here? 3) Documentation could be a bit more helpful, explaining what those are used for: + --upload-public-path dir Set a user defined upload_public_path. + --upload_public_url url Set a user defined upload_public_url. I know it's not much better for other options. 4) There are still 2 remaining FIXMEs: tools/upload-file.pl: # FIXME The copy must be done in Koha::Uploader, but where? # I (Joubu) did not find a place where the file was completely written push @$uploads, $rec # FIXME replace find with search and let the DB do that Sadly I am the wrong person to ask this :(# 5) I remember a lot of thought went into the current implementation, so wondering if there are possible risks or security issues with this approach that we tried to avoid by using he hash? I will move this to BLOCKED for the moment, but ask for QA opinions on Monday. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
