https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165
Tomás Cohen Arazi <tomasco...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
--- Comment #6 from Tomás Cohen Arazi <tomasco...@gmail.com> ---
Kyle, the patches look correct and actually solve the specific use case you are
tackling. BUT...
$ git grep AddRenewal
shows there are some places in which the branchcode is still calculated outside
and passed:
Koha/REST/V1/Checkouts.pm
circ/renew.pl
misc/cronjobs/automatic_renewals.pl
svc/renew
also some tests, but I guess they are mocking userenv to match what they pass
as parameter, and that's why they are still green.
In some cases it might make sense to use userenv (maybe the staff controllers),
but I'm not sure (haven't checked) if there is an override available on the UI
to allow specifying the branchcode.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
