https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165
--- Comment #7 from Kyle M Hall <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #6) > Kyle, the patches look correct and actually solve the specific use case you > are tackling. BUT... > > $ git grep AddRenewal > > shows there are some places in which the branchcode is still calculated > outside and passed: > > Koha/REST/V1/Checkouts.pm > circ/renew.pl > misc/cronjobs/automatic_renewals.pl > svc/renew > > also some tests, but I guess they are mocking userenv to match what they > pass as parameter, and that's why they are still green. > > In some cases it might make sense to use userenv (maybe the staff > controllers), but I'm not sure (haven't checked) if there is an override > available on the UI to allow specifying the branchcode. This code is only responsible for calculating the branchcode if the renewal is done from the opac. I don't believe any of those calls you listed are opac based, right? Are you prososing we should consolidate all 'branchcode' logic within the sub and remove the branchcode parameter altogether? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
