https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #67 from David Nind <[email protected]> --- What should the status of this be after Tomás's comment? (comment 66) Needs Signoff or Failed QA? I tried to apply the patch and got this - no sure whether this means it has applied cleanly or note: 94748 - Bug 17499: Add Koha-objects for messaging preferences Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17499: Add Koha-objects for messaging preferences Using index info to reconstruct a base tree... M Koha/Exceptions.pm M Koha/Patron.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Patron.pm Auto-merging Koha/Exceptions.pm Also, running the test resulted in the tests failing: prove t/db_dependent/Koha/Patron/Message/* t/db_dependent/Koha/Patron/Message/Attributes.t ............. 1/2 # Looks like you planned 6 tests but ran 4. # Failed test 'Test Koha::Patron::Message::Attributes' # at t/db_dependent/Koha/Patron/Message/Attributes.t line 72. Can't locate object method "_new_from_dbic" via package "Koha::MessageAttribute" (perhaps you forgot to load "Koha::MessageAttribute"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Attributes.t ............. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/Koha/Patron/Message/Preferences.t ............ 1/7 # Looks like you planned 3 tests but ran 2. # Failed test 'Test for a patron' # at t/db_dependent/Koha/Patron/Message/Preferences.t line 99. # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'Test Koha::Patron::Message::Preferences' # at t/db_dependent/Koha/Patron/Message/Preferences.t line 125. Can't locate object method "_new_from_dbic" via package "Koha::BorrowerMessagePreference" (perhaps you forgot to load "Koha::BorrowerMessagePreference"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Preferences.t ............ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 6/7 subtests t/db_dependent/Koha/Patron/Message/Transport/Preferences.t .. 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'Test Koha::Patron::Message::Transport::Preferences' # at t/db_dependent/Koha/Patron/Message/Transport/Preferences.t line 112. Can't locate object method "_new_from_dbic" via package "Koha::BorrowerMessageTransportPreference" (perhaps you forgot to load "Koha::BorrowerMessageTransportPreference"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Transport/Preferences.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/Koha/Patron/Message/Transport/Types.t ........ 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'Test Koha::Patron::Message::Transport::Types' # at t/db_dependent/Koha/Patron/Message/Transport/Types.t line 52. Can't locate object method "_new_from_dbic" via package "Koha::MessageTransportType" (perhaps you forgot to load "Koha::MessageTransportType"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Transport/Types.t ........ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests t/db_dependent/Koha/Patron/Message/Transports.t ............. 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'Test Koha::Patron::Message::Transports' # at t/db_dependent/Koha/Patron/Message/Transports.t line 70. Can't locate object method "_new_from_dbic" via package "Koha::MessageTransport" (perhaps you forgot to load "Koha::MessageTransport"?) at /kohadevbox/koha/Koha/Object.pm line 222. # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Patron/Message/Transports.t ............. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patron/Message/Attributes.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 t/db_dependent/Koha/Patron/Message/Preferences.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 Parse errors: Bad plan. You planned 7 tests but ran 2. t/db_dependent/Koha/Patron/Message/Transport/Preferences.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 t/db_dependent/Koha/Patron/Message/Transport/Types.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 t/db_dependent/Koha/Patron/Message/Transports.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 Files=5, Tests=10, 8 wallclock secs ( 0.04 usr 0.01 sys + 6.58 cusr 0.64 csys = 7.27 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
