https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

--- Comment #72 from Jonathan Druart <[email protected]> 
---
I had a very quick look at the patch. About the tests I would like to see the
subroutines replaced with a call to $builder->build_object when it is the only
thing they actually do.

Example:

sub build_a_test_transport_type {
    my $mtt = $builder->build({
        source => 'MessageTransportType' });

    return Koha::Patron::Message::Transport::Types->find(
        $mtt->{message_transport_type}
    );
}

can be replaced with:

  $builder->build_object({ class => 'Koha::Patron::Message::Transport::Types'
});

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to