http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from M. de Rooy <[email protected]> --- QA Comment: General One pref instead of two prefs would probably be better in terms of managing the number of prefs. But this may be just easier in use. (No blocker) sub removeFieldsForPrefill Somewhat theoretical, but if you would not use barcode and disconnected that field from 952, the function will not work. (No blocker for me) Cookie > This feature keeps track of what to prefill from one session to another (both > in time and user: > if the user disconnects and reconnects, the values are still prefilled. > If a user disconnects and another user logs in, the values are still > prefilled.). You assume that the user runs under the same OS credentials. But if he logs out from the OS and another user logs in, the situation is different of course. The line 439 is intriguing: $cookie = ( $cookie, $itemcookie ); Does that work? (Apparently..) It probably should be = [ .. ]; The cookie parameter of CGI accepts an arrayref. Please correct. URI::Escape Just a question, did not examine this further. But should you use uri_escape_utf8 instead of uri_escape? Please test on chars in 128..255 and above, and report back. Indentation: additem.pl lines 356 to 360; the same for segment 426-442 (followup..) Barcode You are adding this comment somewhere: This code is subject to change in 3.2 That sounds a little bit old now? In the new code you add code for incrementing barcode. Note that additem already contains subroutine _increment_barcode. Why not use that? Followup? Conclusion In general. Looks good to me, but needs some further attention. Note for RM: Paul, I am setting status to Passed QA for this one. It was quite long time in the queue. But it needs some clarification and followups. Matthias is close to you :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
