https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Owen Leonard <[email protected]> --- (In reply to Jonathan Druart from comment #21) > Also can you confirm the following 3 errors are not valid? > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt > FAIL forbidden patterns > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt > FAIL forbidden patterns These templates contain links to external (non-Koha) JavaScript assets: LibraryThing and Babeltheque. > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt > FAIL forbidden patterns > forbidden pattern: Font Awesome icons need the aria-hidden > attribute for accessibility purpose (see bug 25166) (line 124) That's a valid warning and has been corrected. (In reply to Jonathan Druart from comment #22) > 1. https://snipboard.io/9kNAL8.jpg > Don't you think the login inputs are too wide? I've added a max-width to the form. > 2. https://snipboard.io/TlIkcu.jpg > The relevance dropdown is too wide Fixed. > 3. https://snipboard.io/apKe35.jpg > Why did you change the order of the filters at the bottom of the adv search > page? I made a lot of changes when working on the responsive behavior of this page. I think the change in the order is unintentional. > 4. https://snipboard.io/vq2I57.jpg > The [+][i] links don't behave correctly. Fixed. > 5. https://snipboard.io/H3xOZK.jpg > I was surprised by the brightness of the green and noticed that there is a > change. > Compare the "Go" button (in the header): I made changes across the board to buttons to make them more consistent with each other. The buttons in your example screenshot have been made to match the style of the "Go" button in the header. Other buttons, like the "Search" buttons on the advanced search page, have been styled the same where previously they used out-of-the-box Bootstrap "btn-success" colors. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
