http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #40 from Paul Poulain <[email protected]> --- QA comment * the database changes says: ADD CONSTRAINT subscription_ibfk_1 FOREIGN KEY (periodicity) REFERENCES subscription_frequencies (id) ON DELETE SET NULL ON UPDATE CASCADE, ADD CONSTRAINT subscription_ibfk_2 FOREIGN KEY (numberpattern) REFERENCES subscription_numberpatterns (id) ON DELETE SET NULL ON UPDATE CASCADE ON DELETE SET NULL = I would have preferred ON DELETE RESTRICT, but SET NULL is OK. * koha-qa.pl show many QA (most minor: :utf8 mistakes) problems: - C4/Serials/Frequency.pm FAIL critic FAIL - C4/Serials/Numberpattern.pm FAIL critic FAIL - serials/create-numberpattern.pl FAIL critic FAIL - serials/subscription-frequency.pl FAIL critic FAIL - serials/subscription-numberpattern.pl FAIL critic FAIL QUESTION : why in the FR-fr samples do you have english strings (and not french) : diff --git a/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql b/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql shouldn't : + ('2/day', 'day', 1, 2, 1), + ('1/day', 'day', 1, 1, 2), + ('3/week', 'week', 1, 3, 3), + ('1/week', 'week', 1, 1, 4), + ('1/2 weeks', 'week', 2, 1, 5), + ('1/3 weeks', 'week', 3, 1, 6), be + ('2/jour', 'day', 1, 2, 1), + ('1/jour', 'day', 1, 1, 2), + ('3/semaine', 'week', 1, 3, 3), + ('1/semaine', 'week', 1, 1, 4), + ('1/2 semaines', 'week', 2, 1, 5), + ('1/3 semaines', 'week', 3, 1, 6), (if yes, please confirm -so i can ask koha-translate mailing list for SP, IT, NO,... translations, and provide a french version) marking failed QA for now, I have no other QA comment (spent almost 1H checking the code). (I haven't tested this patch yet, will do once it passes QA) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
