https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057
--- Comment #9 from Nick Clemens <[email protected]> --- I think I follow some of the logic, this is all very complex. I believe that this fix is still 'correct' though, i.e. we are fixing a separate issue that is definitely wrong. It leaves more work to do, but that should eb another bug. (In reply to Joonas Kylmälä from comment #8) > Even after this change I think we still calculate the availability wrong, in > version f09e2ca27ee8 where the analytics item reserve support was added it > seems to have really checked just based on the analytic record's > reservability without considering whether a hold can be placed to the item > also in the host record. The issue is that after the analytics code was > merged the following incompatible code was introduced: > > > } elsif ( $on_shelf_holds == 2 ) { > > This is in IsAvailableForItemLevelRequest(). This code block checks in this > case the host record's result for: > > > ItemsAnyAvailableAndNotRestricted( { biblionumber => $item->biblionumber, > > patron => $patron }); > > which as far as I understand differs from the original implementation in > f09e2ca27ee8 (though back then there seemingly was no on shelf circ rules). > The bug seems to have started occuring after the following commit: > > Bug 15534 - Add the ability to prevent a patron from placing a hold on a > record with available items (4e1d7a16896787) > > It appears to not have taken into account that for analytic items' case we > need to check the items for the biblio we are placing the hold for and not > the host biblio's items. > > Quite many things should be changed in our code to fix the situation. Nick, > did you get a hold of what I just explained, do you see the problem? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
