https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733
Fridolin Somers <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #2 from Fridolin Somers <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #0) > --- > > There are a few fixes like > <span>Payment</span>[% ELSE %]<span>Transaction</span>[% END %] type: > </label> > ↓ > <span>Payment type</span>[% ELSE %]<span>Transaction type</span>[% END %] > type: </label> > because having "type" separated removes the context and it locks the word > order as same as English. Which makes this string not possible to correctly > translate in French, Spanish and Esperanto for example. In text above you forgot to remove 'type' in second line, after [% END %]. But it is OK in patch : - <label for="[% type | html %]_type" class="required">[% IF type == 'payment' %]Payment[% ELSE %]Transaction[% END %] type: </label> + <label for="[% type | html %]_type" class="required">[% IF type == 'payment' %]<span>Payment type</span>[% ELSE %]<span>Transaction type</span>[% END %]: </label> Still I think there is a problem. This will lead to the translation of : "Payment type" "Transaction type" "%s: " Usually the ":" is with translated text : "Payment type: " "Transaction type: " For example french translation will add a space "Type de transaction : " But this may generate strings with and without ending character : "Payment type" "Payment type: " You may add a span for ending character alone : + <label for="[% type | html %]_type" class="required">[% IF type == 'payment' %]<span>Payment type</span>[% ELSE %]<span>Transaction type</span>[% END %]<span>: </span></label> But the context may be hard to understand for translators. And there are soooooo much places to change. Great work BTW ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
