https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733
--- Comment #7 from Victor Grousset/tuxayo <vic...@tuxayo.net> --- Hola Bernardo :D (In reply to Bernardo Gonzalez Kriegel from comment #5) > In > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=134908&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/ > overdue.tt_sec1 > you enclose only "Items" between <span>..</span>, but not "Item" and > "overdue as of", that's deliberate? > > The original string was > msgid "%s %sItems%sItem%s overdue as of %s%s " > and the new one > msgid "%sItem%s overdue as of %s%s " Yes that's the intended result. To still keep some context, I hesitated and didn't have a strong opinion about what is better. Now that I reread it there would be no ambiguity. So better isolate every piece, right? Now that you are here I can ask what should I do about semicolons? Should I always include them in the string? I left part of them out because I guess I would help RTL languages: > And also I included semicolons in the <span> when the context allows for a > translated version with the semicolon on the left to make sense. If the > context has a related thing just after on the same line (on the right) to the > string, then I didn't include the semicolon to leave it "pointing" at the > right thing. Even though that's wrong, but we can't swap the phrases. > caveat: I don't have any experience in translating RTL in Koha so I'm not > sure if these things help. > And I just noticed we have an RTL CSS that might actually swap stuff. If > that's the case, the fact that I left the semicolon outside the <span> might > not be an issue because it should end up swapped right? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
