https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #11 from David Cook <[email protected]> --- Comment on attachment 134209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134209 Bug 29623: Cache circulation rules Review of attachment 134209: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29623&attachment=134209) ----------------------------------------------------------------- ::: Koha/CirculationRules.pm @@ +379,5 @@ > + my $memory_cache = Koha::Cache::Memory::Lite->get_instance; > + my $cache_key = sprintf "CircRules:%s:%s:%s:%s", $rule_name // q{}, > + $categorycode // q{}, $branchcode // q{}, $itemtype // q{}; > + > + Koha::Cache::Memory::Lite->flush(); It looks like the $memory_cache and $cache_key variables are initialised but unused? @@ +410,4 @@ > push( @$rule_objects, $rule_object ); > } > > + Koha::Cache::Memory::Lite->flush(); Is this necessary since the cache should be cleared at the end of the HTTP request? Or is this to provide for cases where the method is called outside a HTTP context? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
