https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106
--- Comment #17 from Tomás Cohen Arazi <[email protected]> --- (In reply to Marcel de Rooy from comment #16) > Please provide feedback for this change: > > - <xsl:attribute > name="href">/cgi-bin/koha/catalogue/search.pl?q=Host-item:(<xsl:value-of > select="str:encode-uri(translate(marc:datafield[@tag=245]/marc: > subfield[@code='a'], '/', ''), true())"/>)</xsl:attribute> > > + <xsl:attribute > name="href">/cgi-bin/koha/catalogue/search.pl?q=<xsl:value-of > select="str:encode-uri($title_query, true())"/></xsl:attribute> > > You remove translate ? What I said: > I think those translations were added because we just didn't quote the string > as this patch is doing. in fact, such 'fixes' should be engine-specific and > dealt with in the Koha::SearchEngine::{engine}::QueryBuilder module instead. > I would > like to hear from David and Nick before moving on with just > removing the translates, but the feeling is... we were doing things wrong > (not quoting) and working around things... We can bring them back. But the fact that some places remove parenthesis, and others the slash smells... a lot. My testing showed that they are not taken into account in Zebra, and being quoted makes the query not break, which is why those got removed. See comment 5 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
