https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Tomás Cohen Arazi <[email protected]> --- (In reply to Marcel de Rooy from comment #16) > Please provide feedback for this change: > > - <xsl:attribute > name="href">/cgi-bin/koha/catalogue/search.pl?q=Host-item:(<xsl:value-of > select="str:encode-uri(translate(marc:datafield[@tag=245]/marc: > subfield[@code='a'], '/', ''), true())"/>)</xsl:attribute> > > + <xsl:attribute > name="href">/cgi-bin/koha/catalogue/search.pl?q=<xsl:value-of > select="str:encode-uri($title_query, true())"/></xsl:attribute> > > You remove translate ? > > Similar example: > - <xsl:attribute > name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of > select="str:encode-uri(translate(marc:subfield[@code='t'], '()', ''), > true())"/><xsl:if test="marc:subfield[@code='a']">+AND+au:<xsl:value-of > select="str:encode-uri(translate(marc:subfield[@code='a'], '()', ''), > true())"/></xsl:if></xsl:attribute> I traced the introduction of this translate to Katrina, bug 5959 [1] and bug 4506 [2] repectively. I'm pretty sure what I did correct. If you look at the history of the MARC21slim2intranetDetail.xsl file, you will notice we slowly removed (, ) and / as things exploded in different scenarios and last thing we did was wrapping in parenthesis. Quoting the string and escaping double quotes in it is the sensible next step :-D [1] c0ca9f3413d4c069565595919eced6ddf02e8f96 [2] d3605d9ae8d31953df1aed6c04631a578b690fcd -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
