https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer <[email protected]> --- 1) We have a mix now of $flags->{superlibrarian} == 1 and $patron->is_superlibrarian I remember that is_superlibrarian was created in order to fix and avoid a lot of false/wrong permission checks for superlibrarian in the codebase. I am not sure if the flags will work correctly, maybe someone else could weigh in? Should we be consistent or doesn't it matter? 2) Database update UPDATE borrowers SET flags = flags + (1<<29) WHERE flags & 4 Can you explain that one to me? I have written stuff like that before, but it's not coming back to me right now. I had expected something like "where flags != 0 and IS NOT NULL"? 3) Changing home library The staff user can still change their own home branch and circumvent the limitation that way. Should we make the library read only when the permission is missing? These are mostly questions, hope we can move this forward! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
