https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624
--- Comment #44 from Katrin Fischer <[email protected]> --- > > 2) Database update > > > > UPDATE borrowers SET flags = flags + (1<<29) WHERE flags & 4 > > > > Can you explain that one to me? I have written stuff like that before, but > > it's not coming back to me right now. I had expected something like "where > > flags != 0 and IS NOT NULL"? > > Using 1<<29 since borrower.flags is stored in bits. It's the bitwise > operator '<<'. (right shift) I used in order to preserve other permissions > set in borrower.flag. It takes the original value and adds (1<<29). I understood that part, I was wondering about the flags & 4 in the where condition :) > > > 3) Changing home library > > > > The staff user can still change their own home branch and circumvent the > > limitation that way. Should we make the library read only when the > > permission is missing? > Good point. Do you think that is within the scope of this bug? I am torn, I think it would make it feature complete, but also ok to handle as a follow-up. What do you think? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
