https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36569
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from David Cook <[email protected]> --- First, I think this is awesome. Lately, we've been talking at the office a lot about this exact topic, so this is great to see. However, I think we'll want to be very careful with this change. For instance, I don't think it should be backported, since any library with a large action_logs table will take a long time to upgrade. Or - as you note - they could have a volume full if they don't have enough disk space. I wonder if this is a case where we should update kohastructure.sql so that new databases have a good default, but not have an automatic upgrade of the action_logs. We are working on displaying a database audit in about.pl so that could be a good place to give people information about how to manually fix the action_logs indexes at a better time of their choosing... I suppose another option would be to have an arbitrary threshold where an automatic database fix does happen for action_logs tables under a certain size... I don't know. Maybe we should put this one to the koha-devel listserv... -- Questions: 1. How did you decide on 30 for the character length? I think SYSTEMPREFERENCE should be the longest "module" officially, and that's only 16 letters, so 30 seems pretty good. I suppose we're relying on plugins and customizations not having added any "module" longer than 30 characters... I'm tempted to do query some prod databases to see if I can find anything unexpected in those columns. 2. Is the use of "CHARACTER SET ascii COLLATE ascii_general_ci" designed to keep the bytes allocated as small as possible? I think there's merit to that. We default to utf8mb4 which is going to be overkill for those columns, which should never be anything but ASCII, so I think it's good thinking. It might be worth adding a comment to kohastructure explaining why the choice of ASCII so that someone in the future doesn't undo it by accident. 3. The collation is missing in the "bug_36569-compact-action_logs-indices.pl" update. I haven't tested, but is that OK? Is it implied in MySQL from the charset? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
