https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #10 from David Cook <[email protected]> --- Hmm sounds interesting. There's all kinds of interesting/useful things you could do with a plugin hook like this. I'm not sure about the plugin method name. Despite this bug's title, I suppose you wouldn't be required to "modify" the user. This is just a method that is running after the user has been returned by a successful authentication. Hmm... I notice that there isn't a test on $patron, so the plugin author needs to make sure to add their own test to $patron to handle first time logins. I suppose that's OK, since you might want to update the $mapped_data. I wonder if the plugin name should reference OIDC/Oauth2 since at the moment it would only work for those protocols, but the hook is added to the base class Koha::Auth::Client... It seems that you'd need a different plugin hook for SAML though, so I think maybe it would be worth adding a prefix/suffix to the plugin method name... I better run, but overall I like the idea of this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
