https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #12 from Raphael Straub <[email protected]> --- (In reply to David Cook from comment #10) > I'm not sure about the plugin method name. Despite this bug's title, I > suppose you wouldn't be required to "modify" the user. This is just a method > that is running after the user has been returned by a successful > authentication. Hmm... Yes, as this hook can do many things, I had the idea to name it "auth_client_get_user" after the namespace and method that calls it. > I wonder if the plugin name should reference OIDC/Oauth2 since at the moment > it would only work for those protocols, but the hook is added to the base > class Koha::Auth::Client... > > It seems that you'd need a different plugin hook for SAML though, so I think > maybe it would be worth adding a prefix/suffix to the plugin method name... I intentionally added the hook to the base class so that all authentication methods based on it use the same hook. You are right, currently, this is only OIDC/OAuth2, but I suppose that there will be additional authentication methods in the future. If we add some prefix/suffix to the plugin method name that indicates the authentication method, all plugins depending on that hook would have to be updated if the plugin method name changes because of additional authentication methods. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
