https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888
--- Comment #14 from Marcel de Rooy <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #13) Thanks for taking a look. > So IIUC the contention is that authorities is an existing table and adding a > deleted flag will cause it to be forgotten to be checked for in places => so > bad bugs. > VS having a separate table, which causes bad bugs. Please explain why a separate table causes bad bugs. Some issues that we experienced in the past were related to autoincrement. And note that I deliberately removed the autoincrement here from the deleted table. > Introducing a flag will cause bugs only on that moment. (found and fixed in > the next months) Hopefully :) One could argue that having one table requires more careful coding and is therefore more error prone? > Does having a separate table causes bugs over time or will that also be on > the moment of introduction? In other words, were the bugs due to the other > deleted* tables always there? Or were they more recent due to other changes > and it's easier to introduce bugs than with a deleted flag? See above too. I am having the strong imnpression that the option with a flag might introduce more bugs than the current development. Touching more code etc. Some related questions: Why enforce something here that we have not been able to do in the last 6 years for a few similar tables? And what about: I opened this bug close to 2 years ago. And already mentioned the 'merging tables' discussion in my description. When I finally submit code, the whole discussion is revived. Is that fair? This small patch set is imo ready to be used but now the whole things must be designed differently? Will add yet another comment about the two scenarios from a more general perspective more or less proving that both ways have pro and cons. We cannot say here that the deleted flag-option should be better. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
