https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888
--- Comment #16 from Victor Grousset/tuxayo <[email protected]> --- (In reply to Marcel de Rooy from comment #14) > Please explain why a separate table causes bad bugs. Some issues that we > experienced in the past were related to autoincrement. Hm, I though bug 19532 comment 5 was about more stuff than autoincrement. Because these are indeed reliably avoidable now that it's known. > > Introducing a flag will cause bugs only on that moment. (found and fixed in > > the next months) > > Hopefully :) One could argue that having one table requires more careful > coding and is therefore more error prone? When doing delete flags, there should be something in the data layer to by default query only the non deleted data. Otherwise it will be hard to never forget to filter. And code everywhere will have some additional complexity to filter the data. It's a bit of code duplication in many places. Do we have all/almost all the interactions with the authorities table in the data layer? Otherwise it's not sure it's possible to deal with these issues :/ > Some related questions: > Why enforce something here that we have not been able to do in the last 6 > years for a few similar tables? Here, there is no tombstone table so introducing the flag is less work than doing that + removing the tombstone table. Still more work than for a totally new table like recalls. But before that, the question is, should we even avoid introducing a tombstone table? That's suddenly not as clear. > Will add yet another comment about the two scenarios from a more general > perspective more or less proving that both ways have pro and cons. > [...] > Please read this on dba.stackexchange.com: > https://dba.stackexchange.com/questions/14402/tombstone-table-vs-deleted- > flag-in-database-syncronization-soft-delete-scenari/14419 From the discussions and attempts to switch to delete flags in the last years, it seemed a given that a tombstone table was an anti-pattern but it turns out totally not 😱 Back to trying to find the contention point: Now that it's known how to avoid autoincrement issues with tombstone tables, do they have a significant drawback for our use case? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
