https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #101 from Victor Grousset/tuxayo <[email protected]> --- It works :) (readded Pedro's SO line that was lost in Comment 91 changes) It functionally makes sense, found nothing out of order after some exploratory testing on opac, staff and ILS-DI. Thanks David for the earlier testing and notes :) REST API doesn't seem to have a way to place holds so nothing to see there. Like Pedro, I'm not confident in understanding alone enough the completeness and correctness of the many changes in C4/Reserves.pm and opac-reserve.pl to fully QA. But let's try going with this since we both found no obvious issue in the code. The RM is free to request more review. Works, makes sense, QA script happy, code looks good, passing QA :) -- @Arthur: For releases notes, it would be clearer if the name of the ticket was something like: «"OPAC item level holds" circulation rules are not followed by ILS-DI» Do you confirm that's the fix in a nutshell? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
