https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665
Phil Ringnalda <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #20 from Phil Ringnalda <[email protected]> --- It looks like the intent of this patch got lost over time. It wasn't trying to fix what happens when you press Ctrl+C, or when you right-click and select Copy. What it did was use the now-deprecated execCommand("copy") to immediately copy the entire contents of whatever subfield contains the double-click-selected word after you double-click. You can still see that working in current Chrome: double-click within the number of an ISBN, then without doing anything to try to copy, just go over to the search inputs on the left and paste into one. In Chrome, you'll paste that ISBN without an a in front of it. But in current Firefox, you'll paste whatever was already in your clipboard, because it doesn't copy in Firefox. But then to see why silently copying the whole subfield is a bad idea, imitate having a record with multiple misspellings of a word that you want to fix by copying the correctly spelled word and pasting it over the misspelling: 1. Copy the word misspelled 2. In the advanced editor, in Chrome, with this patch applied, in any convenient field like 245$a, type The mispelled word. 3. Double-click mispelled and press Ctrl-V Oopsie! Instead of pasting misspelled which you thought was in your clipboard, you pasted The mispelled word, because double-clicking just one word copied the whole subfield contents, overwriting your clipboard. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
