https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735
--- Comment #5 from Nick Clemens (kidclamp) <[email protected]> --- (In reply to Emily Lamancusa from comment #2) > Submitting for feedback - this seems to work, but there are a couple of > things I'm not sure about: > - I kept the uri TT filters from the existing code. Should those be changed > to html instead since they're not being passed in the URL anymore? Correct, they should all be html filters now. In the end we are building a form and submitting, so they won't be in a URL > - I feel like there has to be a better way to handle the dependency between > the .inc file and the JS file, but including the JS asset directly in the > .inc file breaks things (I think because the include is added in the middle > of the page in request.tt, which violates the coding guideline of including > JS assets at the end?) I think I understand the issue, it seems odd to have the JS asset in the script and not in the include directly? In this case, the include is only used on this page, but perhaps adding a comment to the include to specify that it needs the asset would be helpful? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
