https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044
--- Comment #87 from Pedro Amorim <[email protected]> --- (In reply to Julian Maurice from comment #82) > 1) In the patches: > > #FIXME: The above $subscription->{additional_fields} may be redundant. > > Remove if so. > Can it be checked/fixed now ? > > 2) With the patches it is no longer possible to save a "falsy" value like '' > or '0'. That's a regression and it would be nice to add a test for that. > > 3) I was a bit surprised when I realized that repeatable AV fields are not > actually repeatable. There is no "+ New" button like with other repeatable > fields. > It makes sense in this case to have a list of checkboxes instead of a > repeatable dropdown list, but I didn't expect that. So maybe the issue is > with the term "repeatable". I think that "multivalued" would fit better. > Is it feasible to change that term without too much work ? > Can anyone else from QA team or release team give their opinion on this ? > > Failing QA for 1 and 2 Thank you very much for your time here, Julian. I believe my 3 latest QA follow-up patches address 1) and 2). Please let me know if you disagree. As for 3) I agree with you, but don't feel strongly either way. I adopted the 'repeatable' naming to be consistent with patron attribute types, even though the 'repeatable' in patron attribute types only works for text fields, not AV fields, with that not being clear from the UI. My long term goal for additional fields + borrower patron attributes is to eventually merge these 2 features (they're essentially the same thing, written twice). But I'm happy to follow-up with the renaming if required. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
