https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #89 from Julian Maurice <[email protected]> --- About the '' value, I agree that it doesn't make much sense to keep them. But it's a change in behavior, and maybe someone out there uses these empty values in some way. If we decide to not keep the empty value we should at least advertise it in the release notes (and in the commit messages, but you already did that) And I think that the updatedatabase should remove these empty values Other things to fix: 1) add_additional_fields does not allow '0' as a value, so it's not possible to add this value in subscriptions batch edit (the only place where add_additional_fields is used) 2) There is a piece of code that does nothing in koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt: $("#repeatable").prop('checked') == true It's not an "if" condition and it appears on the same line as the end of a block so I assume this must be a copy/paste mistake 3) In koha-tmpl/intranet-tmpl/prog/js/additional-fields-entry.js functions clone_entry and clear_entry are added to the global scope. To avoid that you should wrap the whole script inside a block like this: (function () { // code goes here })(); 4) QA script failure: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column additional_fields.repeatable is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/AdditionalField.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
