https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594
--- Comment #7 from CJ Lynce <[email protected]> --- Created attachment 170298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170298&action=edit Bug 36594: Library hours display issues The following issues existing when displays library hours in koha/admin/branches.pl -For newly created or edited libraries, 'null' is displayed when that time is undefined. -Time is displayed with seconds, which are not necessary. -The system preference CalendarFirstDayOfWeek is not respected when viewing a specific library with hours defined. This patch corrects these issues: -Undefined values are properly handled. All open & close times are undefined, the library is considered as not having hours set. -If open and close times for a day are both undefined, the library is considered closed. -Time is now displayed in the format HH:MM -CalendarFirstDayOfWeek is respected when viewing a library with defined hours. To Test: 1. Login to staff interface 2. Go to Koha administration > Basic parameters > Libraries 3. Edit any library or create a new library. Do not set hours. Save. 4. On the library list, in the hours column, all days are displayed with null. 5. Edit or create a 2nd library, set some hours, leaving at least one day without hours. Save. 6. In the library list, in the hours column, defined times are in the format HH:MM:SS. 7. Edit the system preference CalendarFirstDayOfWeek to set a day other than Sunday as the first day of the week. 8. Return to Go to Koha administration > Basic parameters > Libraries 9. Click on the name of a specific library with hours to view details. 10. The order of the calendar week still starts with Sunday. 11. Apply Patch. 12. Return to Go to Koha administration > Basic parameters > Libraries 13. Check that your library with all undefined times shows "Library hours not set". 14. Check that your library with defined hours is showing times in HH:MM format, and days without defined hours are "Closed". 15. Click on the name of a library with hours to view details. Verify that the calendar week starts respects CalendarFirstDayOfWeek. 16. Click on the name of another library without hours to view details. Verify these libraries show as "No opening hours have been set" in the branch detail view. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
