https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the display of
      release notes|                            |library hours in the staff
                   |                            |interface (Administration >
                   |                            |Basic parameters >
                   |                            |Libraries):
                   |                            |- If there are
                   |                            |no opening and closing
                   |                            |times entered for all the
                   |                            |days of the week, then the
                   |                            |library hours column
                   |                            |displays as "Library hours
                   |                            |not set" (instead of
                   |                            |displaying a table with all
                   |                            |the days and null for each
                   |                            |time; editing the library,
                   |                            |without entering any times,
                   |                            |was also displaying the
                   |                            |table).
                   |                            |- If no values are
                   |                            |entered for a day's opening
                   |                            |and closing times, the
                   |                            |library is considered
                   |                            |closed and now displays as
                   |                            |"Closed" for the day
                   |                            |(instead of displaying
                   |                            |null).
                   |                            |- The opening and
                   |                            |closing times are now
                   |                            |displayed in the format
                   |                            |HH:MM (instead of
                   |                            |HH:MM:SS).
                   |                            |- The
                   |                            |CalendarFirstDayOfWeek
                   |                            |system preference is now
                   |                            |used when viewing a library
                   |                            |with opening and closing
                   |                            |times set (instead of
                   |                            |always displaying Sunday as
                   |                            |the first day of the week).

--- Comment #12 from David Nind <[email protected]> ---
Thank you for providing a patch to fix this!

I've added a draft release note - feel free to update it if I haven't got it
right.

Some other things I noted - for fixing on other bugs:

1. Entering the time manually: you can only manually enter the time up to 12 in
either of the open or close time input fields (irrespective of the TimeFormat
system preference) - for example, for the close time column you can't manually
enter 14:00 (you can select it from the input control)

2. When editing the opening and closing times, if you select the X it then
displays the date picker.

3. Using the TimeFormat system preference: the selector takes this system
preference into account, but then displays the time using 24 hours (for
example: entering 4:00 PM as the closing time displays as 16:00).

4. Text inconsistencies - I have created bug 37662 for these: 
   4.1 If no library opening and closing times are set, it displays in the
library hours column as "Library hours not set". However, if you view the
library details (selecting the library name in the name column), the text is
"No opening hours have been set."
   4.2 The column name in the list of libraries is "Library hours". However, if
you view the library details (selecting the library name in the name column),
the field label is "Opening hours". "Opening hours" is also used as the field
label when adding and editing library information.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to