https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
Victor Grousset/tuxayo <vic...@tuxayo.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #55 from Victor Grousset/tuxayo <vic...@tuxayo.net> ---
Thanks for the follow-up :D
----
Any sponsor of this quite long enhancement?
---
QA notes:
prettier ok (JS14) on all vue, js and ts files touched.
- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsDisplay.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
- t/cypress/integration/AdditionalFields_spec.ts
This new file needs a /* keep tidy */ comment on top:
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js
It's also a good opportunity to add a /* keep tidy */ comment on top of this
file:
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
To avoid having to manually check it with prettier.
----
there are two
cy.get("#licenses_list table tbody tr:first td:first a").click();
IMHO either they should get a comment to easily know what's clicked when in the
future there will be some change to the structure of the table and the test
will break.
Or to prevent breakage and documenting at the same time, an id or a class could
be added to what's being clicked (or it's parent) so the selector speaks for
itself and would be much less likely to break with future changes.
---
found two instances of forgotten
// cy.wait("@avcategories");
---
tip: (not a QA worry to be addressed)
I think it's okay to add a class or id from time to time facilitate selection
to make the tests more concise by avoiding the need for sibling circumvention,
such as .parent().children("input")
And also be able to handle cases without an easily selectable sibling. Like in
the previous case of "#licenses_list table tbody tr:first td:first a"
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
