https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
--- Comment #57 from Pedro Amorim <pedro.amo...@ptfs-europe.com> ---
Thank you, Victor.
I've squashed the removal of commented cy.wait("@avcategories"); to the squash
qa follow-up patch.
I've also added sponsored-by lines.
(In reply to Victor Grousset/tuxayo from comment #55)
> This new file needs a /* keep tidy */ comment on top:
> koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js
>
> It's also a good opportunity to add a /* keep tidy */ comment on top of this
> file:
> koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
> To avoid having to manually check it with prettier.
No api.js files under js/vue/fetch have this. If this is reason to FQA it
should at least be flagged by the QA script first then.
> there are two
> cy.get("#licenses_list table tbody tr:first td:first a").click();
>
> IMHO either they should get a comment to easily know what's clicked when in
> the future there will be some change to the structure of the table and the
> test will break.
> Or to prevent breakage and documenting at the same time, an id or a class
> could be added to what's being clicked (or it's parent) so the selector
> speaks for itself and would be much less likely to break with future changes.
This is an established pattern utilized in all cypress spec files to click on
the first element of a table (to navigate to it). I can see your point but
table rows don't usually have an id. I'm on board for filing a new bug titled
"Add id to table rows to be more easily selected by cypress tests" but I don't
see how this should be in the scope of this patchset.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
