https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224
--- Comment #53 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Jonathan Druart from comment #51) > Shouldn't we filter by default? > > 166 if ( $params->{embed_items} ) { > 167 push @filters, 'EmbedItems'; > 168 if ( $params->{interface} && $params->{interface} eq 'opac' > ) { > 169 $options->{items} = > $self->items->filter_by_visible_in_opac( > > If we don't pass 'opac' we do not filter. If we forget it then it's not > filtered either. The original implementation falled back to 'opac'. If we want to make sure, we could make the `interface` parameter mandatory and throw an exception if missing. I'd agree with a follow-up implementing it. (In reply to Jonathan Druart from comment #52) > Shouldn't Koha::OAI::Server::Repository->get_biblio_marcxml call this with > expand_coded_fields? Yes. > Same for Koha::REST::V1::Biblios->get_public, use metadata_record and remove > 'ViewPolicy'? Yes. --- Overall, I implemented `metadata_record` and provided a sample usage patch. Martin's attempt to use it everywhere might have missed some places. But some might better be handled on their own bugs. As we tried to keep the scope small (i.e. replace `$biblio->metadata->record(*)` with `$biblio->metadata_record(*)`. I agree with all your remarks, Jonathan. And can work on that if you don't beat me to it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
