https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224
--- Comment #54 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Jonathan Druart from comment #51) > Shouldn't we filter by default? > > 166 if ( $params->{embed_items} ) { > 167 push @filters, 'EmbedItems'; > 168 if ( $params->{interface} && $params->{interface} eq 'opac' > ) { > 169 $options->{items} = > $self->items->filter_by_visible_in_opac( > > If we don't pass 'opac' we do not filter. If we forget it then it's not > filtered either. I just remembered: in some context we want to apply the ViewPolicy filter (i.e. OPAC and some staff interface views) but in some others we don't want filtering out things i.e. exporting records, etc. That's why it was built like that. Maybe we should force the `interface` param and also add a `skip_view_policy` parameter for select use cases (e.g. record indexing). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
