https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37034

Victor Grousset/tuxayo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|[email protected] |[email protected]
                   |y.org                       |
                 CC|                            |[email protected]

--- Comment #5 from Victor Grousset/tuxayo <[email protected]> ---
Thanks David for the testing and feedback.

(In reply to David Nind from comment #4)
> I've tested, it works, and I've signed it off.
> 
> Some suggestions:
> 1. Add a sample notice similar to Bug 36915
> 2. Rename to booking_expired.pl and BOOKING_EXPIRED (that makes more sense
> to me in English)

+1
(wait, not sure about bookings => booking)

About the sample notice how about this Thibaud?:
It just some changes to BOOKING_CANCELLATION from sample_notices.yml

        - module: bookings
          code: BOOKING_EXPIRED
          branchcode: ""
          name: "Booking expiration notice"
          is_html: 1
          title: "A library booking expired"
          message_transport_type: email
          lang: default
          content:
            - "[%- PROCESS 'html_helpers.inc' -%]"
            - "[%- USE KohaDates -%]"
            - "Dear [%- INCLUDE 'patron-title.inc' patron => booking.patron
-%],<br>"
            - "<br>"
            - "We regret to inform you, that the following booking has
expired.<br>"
            - "<br>"
            - "Title: [%- INCLUDE 'biblio-title.inc' biblio=booking.biblio link
= 0 -%]<br>"
            - "<br>"
            - "Dates: [% booking.start_date | $KohaDates %] to [%
booking.end_date | $KohaDates %]<br>"
            - "<br>"
            - "Kind regards<br>"
            - "<br>"
            - "[% booking.pickup_library.branchname %]"

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to