https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37034
--- Comment #6 from Victor Grousset/tuxayo <[email protected]> --- Without a notice existing, it fails with Can't "next" outside a loop block at misc/cronjobs/bookings/bookings_outdated.pl line 130. code: unless ($template_exists) { $verbose and print qq|Message '$lettercode' content not found\n|; next; } It's indeed not in a loop. And it should output the message even if it's not verbose since it's a fatal error. ------ -lettercode param doesn't match terminology. https://wiki.koha-community.org/wiki/Terminology#N «Use "notice", not "letter".» Would `-notice-code` work well? (I can spot naming issues but not always propose names being sure they have no issue :P) ----- POD contains "bookings_overdated.pl" (5 occurrences) -------- There is redundancy when running --help ``` Usage: bookings_overdated.pl -lettercode <notice to send> [ -c ][ -v ] Options: -help brief help message -v verbose -lettercode <lettercode> predefined notice to use, default is BOOKING_OUTDATED Options: -help Print a brief help message and exits. -v Verbose. Without this flag set, only fatal errors are reported. -lettercode Optional parameter, choose a notice to use. Default is 'BOOKING_OUTDATED'. ``` You can look at misc/cronjobs/sftp_file.pl there is something (I didn't found what exactly ^^") that makes =head1 OPTIONS not being outputted. So no duplication with the " Options:" in SYNOPSIS ------------- What is [ -c ] ? Is that a rest from a --confirm that came from another cron job? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
