https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221
--- Comment #69 from Katrin Fischer <[email protected]> --- (In reply to Pedro Amorim from comment #66) > (In reply to Katrin Fischer from comment #62) > > (In reply to Katrin Fischer from comment #61) > > > Fixed some more "Please Note". > > > > > > This here is not correctI bleive with the mix of concatentation and __() > > > > > > + $('#custom-warning').text(__('The name "' + val + '" is not > > > permitted')).show(); > > > > > > Can you please follow-up on this? > > > > To verify I did a gulp po:update --lang de-DE > > cd misc/translator/po > > git grep "is not permitted" but it didn't show up. > > I may be wrong, but I think this will never work, because gulpfile.js is > extracting messages from the following dirs: > 'koha-tmpl/intranet-tmpl/prog/js/vue/**/*.vue', > 'koha-tmpl/intranet-tmpl/prog/js/**/*.js', > 'koha-tmpl/opac-tmpl/bootstrap/js/**/*.js', > > And shared.js we're talking about here is located in: > 'Koha/ILL/Backend/shared-includes/shared.js' > > I've filed bug 38340 a few days ago for this. These files in Standard > backend are designed as DRY, to use the same form logic and javscript for > OPAC+Staff. I think the quick fix would be to duplicate these assets and > move each set to their respective koha-tmpl/intranet|opac-tmpl directories, > but this would be duplicating code. > Ideally, with bug 35716, we could move these but not have them duplicated, > but I don't think bug 35716 is trivial. Thoughts? I think a quick fix for stable releases would be good as this also affects the OPAC (= end users) and then we need to work on a proper fix for the shared assets for 25.05 maybe? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
