https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221
--- Comment #74 from Victor Grousset/tuxayo <[email protected]> --- (In reply to Katrin Fischer from comment #70) > Small glitch: I have reverted the quotes. Strings need to be in "", so that > languages like French using ' inside strings don't break translations (see > coding guidelines). Oh no, almost all stuff above are actually follow-ups for bug 35570. But the issue about simple quotes also applies to changes from this very bug! - '<input type="text" class="custom-name" name="custom_key">' + - '<input type="text" id="custom-value" name="custom_value"> '+ + '<input type="text" class="custom-name ' + + ( opac ? 'form-control input-fluid custom-field-input' : '') + + '" name="custom_key" placeholder="'+__('key')+'">' + + ' ' + + '<input type="text" id="custom-value" name="custom_value" class="' + + ( opac ? 'form-control input-fluid custom-field-input' : '') +'" placeholder="'+__('value')+'"> ' + It might be tricky with the HTML attribute values being double quoted. And maybe Bug 13768 is relevant. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
