http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #96 from Paul Poulain <[email protected]> --- (In reply to comment #95) > > This should not be a system preference. It should be something that's set in > > the koha-conf.xml. Library staff should not be modifying it, as they can't > > ensure that directories are set up with the right permissions. > This is the same for all other system preferences that contain a path. So why > this one is different? At 1st glance, I had the same reaction. But there is a difference : writing ! Other systempreferences only require reading (opacusercss for example), this one will write, and there is no other syspref in this case I think. > Moreover, I don't think a preference for a cataloguing plugin should be in > koha-conf.xml (its place is not in global system preferences either but > there is no other place) I hesitate... what I think is that this preference don't need to be setup during installation, because it's an additional feature that most libraries won't use. (like for ldap for example : there are default values, but the koha-conf.xml must be edited manually if you want to enable it) > I'm not opposed to move this pref in koha-conf.xml, I just want to > understand :) > Also I would like to have someone else's opinion before writing a patch. my conclusion would be: * move the uploadPath to koha-conf.xml * add <uploadPath><uploadPath> (without any value) to default koha-conf * add a disclaimer on the plugin page if uploadPath is empty, saying something like "WARNING : your server is not properly setup, it won't work. uploadPath must be set in koha configuration file" (wait for another feedback before writing the patch) PS: will this patch make it's way one day ? :\ -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
